LBAAS-2800: no region field needed for global lb type #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks AWESOME! Could you include some test coverage for this as well? You can include it in the |
apinonformoso
changed the title
lfundaro-do
approved these changes
Oct 10, 2023
@danaelhe Tests added 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Created a custom diff function to validate that
regionfield is not required if the type file is set toGLOBALand if set toREGIONALvalidateregionvalue is present and not empty.Validation
Verified by running
terraform planfor each casetype=GLOBAL and region="nyc3"
type=GLOBAL and region=""
type=GLOBAL and no region
type=REGIONAL and region="nyc3"
type=REGIONAL and region=""
type=REGIONAL and no region
region="nyc3" and no type
no type and no region